clang-tidy: Use correct compilation flags when compiling C #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jungleraptor
approved these changes
Apr 12, 2023
Contributor
jungleraptor
left a comment
jungleraptor
left a comment
There was a problem hiding this comment.
Great fix.
So one thing is we were passing -Werror before the change (on linux at least), but maybe it wasn't getting added to the clang-tidy compile line because we were setting it as a toolchain feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem of analyzing C source files using
clang-tidy. The problem was that we passed C++ flags even when compiling C source files. Clang-tidy complained about-stdlib=libc++.In order to fix this, I introduced a statement that checks if the extension of the file is "c" and gets the correct compilation flags.
This issue appeared because in PR #67 we enabled
-Werrorby default.Testing
https://github.com/swift-nav/starling/pull/7851
https://jenkins.ci.swift-nav.com/blue/organizations/jenkins/swift-nav%2Fstarling/detail/PR-7851/1/pipeline