Skip to content

Conversation

Copy link

Copilot AI commented Nov 29, 2025

Fixes #359. VATSIM ATIS messages containing placeholder lines (e.g., "z", "z1", "z2") were silently dropped and never displayed to users.

Root Cause

In updateAtisMap(), three return statements inside a for loop exit the entire function when a placeholder line is encountered, preventing the atisReplyReceived signal from being emitted:

// Before: exits function, drops entire ATIS
if (test == "z") return;
if (test.startsWith("z") && test.length() == 2) return;
if (test.length() == 1) return;

Fix

Changed return to continue to skip placeholder lines while still processing remaining content:

// After: skips line, continues processing
if (test == "z") continue;
if (test.startsWith("z") && test.length() == 2) continue;
if (test.length() == 1) continue;
Original prompt

Investigate the reason for issue 359


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Co-authored-by: ltoenning <1716810+ltoenning@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate reason for issue 359 Fix ATIS messages silently dropped when containing placeholder lines Nov 29, 2025
Copilot AI requested a review from ltoenning November 29, 2025 17:02
@ltoenning
Copy link
Member

@tzobler Do you know the reason behind the z1, z2, ... within the ATIS lines? Is this something FSD-specific? I couldn't find any further information about this.

Anyways, this change likely does not explain why updating does not work while the initial ATIS update works fine.

@tzobler
Copy link
Contributor

tzobler commented Nov 30, 2025

@tzobler Do you know the reason behind the z1, z2, ... within the ATIS lines? Is this something FSD-specific? I couldn't find any further information about this.

Anyways, this change likely does not explain why updating does not work while the initial ATIS update works fine.

To my knowledge, the FSD server behaves transparently with regard to ATIS. A typical sequence of events is as follows:

request ATIS from the ATC-client
$CQFSC131:EDDM_CTR:ATIS
answer (example):
$CREDDM_CTR:FSC131:ATIS:V:UseAFV
$CREDDM_CTR:FSC131:ATIS:T:Auckland Tower - ATIS 127.80
$CREDDM_CTR:FSC131:ATIS:T:Charts- vats.im/nz/charts
$CREDDM_CTR:FSC131:ATIS:T:Submit feedback - vats.im/nz/atc-fb
$CREDDM_CTR:FSC131:ATIS:Z:1200
$CREDDM_CTR:FSC131:ATIS:E:3

The number of :T: lines is variable. The :Z: line is not always present. However, the :E: line, which terminates the transmission, is typical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ATIS text not updated

4 participants