Skip to content

Conversation

@ltoenning
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds X-Plane custom dataref support and fixes issues related to COM frequency tuning. The main purpose is to expose Swift connection state and callsign information to X-Plane through custom datarefs, allow tuning COM frequencies to standby (not just active), and remove unused signal connections for airportsInRangeUpdated.

  • Adds a generic CustomDataRef template class to create readable custom datarefs for X-Plane
  • Adds ability to tune ATC frequencies into standby COM channels in addition to active channels
  • Propagates flight network connection state and own callsign to the simulator plugin

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/xswiftbus/datarefs.h Adds CustomDataRef template class for registering custom X-Plane datarefs with read callbacks
src/xswiftbus/custom_datarefs.h Defines two custom dataref traits: network connection state (int) and callsign (string)
src/xswiftbus/service.h Adds member variables for custom datarefs and declares new methods for setting connection state and callsign
src/xswiftbus/service.cpp Implements setFlightNetworkConnected and setOwnCallsign methods, initializes custom datarefs, adds DBus method handlers
src/xswiftbus/org.swift_project.xswiftbus.service.xml Adds DBus method signatures for setFlightNetworkConnected and setOwnCallsign
src/xswiftbus/CMakeLists.txt Adds custom_datarefs.h to the build
src/plugins/simulator/xplane/xswiftbusserviceproxy.h Declares proxy methods for new DBus methods
src/plugins/simulator/xplane/xswiftbusserviceproxy.cpp Implements proxy methods and removes unused airportsInRangeUpdated signal connection
src/plugins/simulator/xplane/simulatorxplane.h Declares setOwnCallsign override
src/plugins/simulator/xplane/simulatorxplane.cpp Implements setOwnCallsign and updates setFlightNetworkConnected to call proxy
src/plugins/simulator/flightgear/fgswiftbusserviceproxy.cpp Removes unused airportsInRangeUpdated signal connection
src/gui/views/atcstationview.h Updates requestComFrequency signal to include active parameter, refactors tuning methods
src/gui/views/atcstationview.cpp Adds standby tuning menu options, consolidates tuneInAtcCom1/Com2 into single tuneInAtc method
src/gui/views/atcstationtreeview.h Updates requestComFrequency signal to include active parameter, refactors tuning methods
src/gui/views/atcstationtreeview.cpp Adds standby tuning menu options, consolidates tuning methods
src/gui/components/atcstationcomponent.h Updates setComFrequency method signature to include active parameter
src/gui/components/atcstationcomponent.cpp Implements logic to set active or standby COM frequency based on parameter
src/core/simulator.h Declares virtual setOwnCallsign method
src/core/simulator.cpp Implements base setOwnCallsign method (no-op)
src/core/context/contextsimulatorimpl.cpp Calls setOwnCallsign when network state changes
src/core/context/contextownaircraft.h Declares updateStandbyComFrequency method
src/core/context/contextownaircraftproxy.h Declares updateStandbyComFrequency proxy method
src/core/context/contextownaircraftproxy.cpp Implements updateStandbyComFrequency proxy method
src/core/context/contextownaircraftimpl.h Declares updateStandbyComFrequency implementation
src/core/context/contextownaircraftimpl.cpp Implements updateStandbyComFrequency to update standby COM frequencies
src/core/context/contextownaircraftempty.h Implements empty/stub updateStandbyComFrequency method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ltoenning ltoenning force-pushed the tune_standby_from_list branch from afbefc3 to ad4da17 Compare December 13, 2025 21:17
@ltoenning ltoenning force-pushed the tune_standby_from_list branch from ad4da17 to 2cb18c5 Compare December 13, 2025 22:23
@ltoenning ltoenning merged commit 2cb18c5 into main Dec 13, 2025
10 of 11 checks passed
@ltoenning ltoenning deployed to github-pages December 13, 2025 23:24 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants