Add a helper function for rendering availability information as HTML #1376
+194
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
heckj
approved these changes
Dec 4, 2025
heckj
reviewed
Dec 4, 2025
| } | ||
| } | ||
|
|
||
| struct MultiValueLinkProvider: LinkProvider { |
Member
There was a problem hiding this comment.
Just to double check my understanding - the MultiValueLinkProvider here is a convenience instance really just for this test scenario, as the upstream usage of parsing availability uses another type that conforms to the LinkProvider protocol - Is that correct?
Contributor
Author
There was a problem hiding this comment.
Yes, there's a "real" link provider here that reads from the documentation context.
That 4000+ LOC PR isn't really meant to be reviewed and merged on its own, so I'm breaking it down into smaller pieces that can be merged individually and incrementally. Unfortunately, that means that some early PRs may add test code that's barely used (yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://163326857
Summary
This is another slice of #1366
It adds a helper function to the
DocCHTML/MarkdownRendererto render availability information as HTML.Dependencies
None.
Testing
Nothing in particular for this PR. It only adds an internal helper function. See #1366 for how it eventually does get used.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded