Skip to content

Conversation

@jerryjrchen
Copy link
Contributor

This includes the library created in swiftlang/swift-testing#1369

Will move out of draft once I build the toolchain and confirm it works as expected.

Resolves rdar://163673609

This includes the library created in swiftlang/swift-testing#1369

Resolves rdar://163673609
<File Source="$(PlatformRoot)\Developer\Library\Testing-$(ProductVersion)\usr\lib\swift\windows\aarch64\_Testing_WinSDK.lib" />
</Component>
<Component Directory="Testing_usr_lib_swift_windows_arm64" DiskId="2">
<File Source="$(PlatformRoot)\Developer\Library\Testing-$(ProductVersion)\usr\lib\swift\windows\aarch64\_TestingInterop.lib" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm admittedly just copying similar examples already here, so I wanted to call this part out. The .lib in my Windows toolchain seems to be static libs:

jerryjrchen@JJC-WINDOWS:/mnt/c/Users/jerryjrchen/AppData/Local/Programs/Swift/Platforms/0.0.0$ file ./Windows.platform/Developer/Library/Testing-0.0.0/usr/lib/swift/windows/aarch64/Testing.lib
./Windows.platform/Developer/Library/Testing-0.0.0/usr/lib/swift/windows/aarch64/Testing.lib: current ar archive

I assume this means we support building both statically and dynamically linked test bundles (binaries?) on Windows?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows exposes library content differently than you're used to. Let's sync up later today and I'll try to share what little I know.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look correct. Please do a cross-repo toolchain build before merging.

The lib files are import libraries (conceptually like a tbd) and the DLL are the runtime bits (conceptually like a dylib).

@jerryjrchen
Copy link
Contributor Author

Confirmed the libraries are in the right locations with a toolchain install:

jerryjrchen@JJC-WINDOWS:/mnt/c/Users/jerryjrchen/AppData/Local/Programs/Swift/Platforms/0.0.0/Windows.platform/Developer/Library/Testing-0.0.0/usr$ find . | grep Interop
./bin32/_TestingInterop.dll
./bin64/_TestingInterop.dll
./bin64a/_TestingInterop.dll
./lib/swift/windows/aarch64/_TestingInterop.lib
./lib/swift/windows/i686/_TestingInterop.lib
./lib/swift/windows/x86_64/_TestingInterop.lib

@jerryjrchen jerryjrchen marked this pull request as ready for review November 3, 2025 20:06
@jerryjrchen jerryjrchen merged commit 7911977 into swiftlang:main Nov 3, 2025
@jerryjrchen jerryjrchen deleted the wix-testinginterop branch November 3, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants