Add-dependency command updates all manifests #9285
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There is still needing tests + option to specify the manifest files a user wants to add-dependencies to. |
Contributor
Author
|
Furthermore, I think that on top of add-dependency, other similar subcommands, such as add-target and add-product, should also support this logic |
cmcgee1024
reviewed
Nov 5, 2025
| // Find version specific manifests | ||
| do { | ||
| let packageContents = try fileSystem.getDirectoryContents(packagePath) | ||
| let regexManifestFile = try! RegEx(pattern: #"^Package@swift-(\d+)(?:\.(\d+))?(?:\.(\d+))?.swift$"#) |
Member
There was a problem hiding this comment.
question: Is there some reusable regex or function that can find all of the package manifests?
Contributor
Author
There was a problem hiding this comment.
No, sadly there is not a reusable regex. Furthermore, the only function that is used for finding package manifests only returns one (which is required for the manifest loader, as you would not load multiple manifests)
Member
|
This change looks good to me. If there were some tests I think that it can be flipped to "ready for review." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add-dependency will update all manifest files in a swift package
Motivation:
#9248
Modifications:
Essentially, just added a function to query all possible manifest files, then apply edits to each one.
Result:
Now, add-dependency can edit multiple manifests at the same time such as swift argument parser.