-
Notifications
You must be signed in to change notification settings - Fork 21
chore(styles): update signal icons through the package
#6544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(styles): update signal icons through the package
#6544
Conversation
|
leagrdv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ithub.com/swisspost/design-system into 6425-update-signal-icons-whereever-needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors form validation icons by replacing dynamic SCSS function-generated SVG icons with CSS custom properties that reference pre-generated signal icons. The change simplifies the icon implementation and aligns validation icons with the design system's signal icon set.
Key changes:
- Removes SCSS icon definitions and functions for error/success/warning icons
- Replaces function-based icon generation with CSS custom property references (
--post-signal-icon-success,--post-signal-icon-error) - Eliminates color parameter variants for high-contrast modes (icons now handle theming internally)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/styles/src/variables/_icons.scss | Removes legacy icon SVG path definitions and map merges for error, success, and warning icons |
| packages/styles/src/functions/_forms.scss | Removes success-icon() and warning-icon() helper functions |
| packages/styles/src/mixins/_forms.scss | Replaces function calls with CSS custom properties, removes unused forms function import |
| packages/styles/src/components/validation.scss | Switches from mask-image mixin to background-image with custom properties, removes icon mixin imports |
| packages/styles/src/components/form-input.scss | Replaces mask-image with background-image and removes color specifications |
| packages/styles/src/components/form-select.scss | Updates all validation states to use custom properties instead of function calls |
| packages/styles/src/components/form-textarea.scss | Changes background positioning to explicit calc values and removes old token references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Related Previews |
|






📄 Description
This PR updates validation signal icons across form components to use CSS custom properties instead of SCSS functions.
Changes
🚀 Demo
https://preview-6544--swisspost-design-system-next.netlify.app/?path=/docs/1aa900d9-aa65-4ae0-b8cd-e6cca6cc3472--docs
🔮 Design review
📝 Checklist