Refactor code for init, pkgFile, functions, and npm modules
#240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor imports to use absolute paths. - Use `join` as `pathJoin` for increased clarity. - Simplify the code by using optional chaining and destructuring assignment. - Update the list of `randomArrayValue` options. - Use `inquirer.prompt` with an array of questions to simplify the code.
- `dependencies` and `devDependencies` objects are extracted from `siteManifest` and assigned default values of `{}` to avoid repeatedly accessing the same properties.
- `reduce` calls in the `dependencies` and `devDependencies` properties have been replaced with `map` calls and the spread operator has been replaced with `Object.assign`. This avoids creating new objects on each iteration of the `reduce` function.
- The optional chaining operator (`?.`) has been removed from the `options.deps` and `options.devDeps` properties and replaced with nullish coalescing operator (`??`) and an empty array. This ensures that the `map` function is always called on an array, even if the property is `undefined`.
- Replace `for` loop with `every` method in `isEmptyDir`. - Replace `for` loop with `Promise.all` and `map` in `createFiles`. - Rename `join` import from `path` to `pathJoin` for increased clarity. - Add comment to `catch` block in `safeStat`. - Improve readability with line breaks and optional chaining.
- Use `get` method from `https` module instead of `request` to simplify the code. - Remove unnecessary `req.end()` call. - Change `close` event to `end` event for resolving the promise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains several refactoring changes to improve the code quality and readability of the
init,pkgFile,functions, andnpmmodules. The main changes are:inquirer.promptwith an array of questions, in theinitmodule.mapcalls, and nullish coalescing operator in thepkgFilemodule.isEmptyDirandcreateFilesfunctions by usingevery,Promise.all, andpathJoinin the functions module.getmethod fromhttpsmodule instead ofrequestto simplify the code in thenpmmodule.Please review the changes and let me know if you have any feedback or suggestions.