fix(material): make appear working #317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesse205
commented
Jun 12, 2025
Jesse205
force-pushed
the
fix/transition-appear
branch
from
124019e to
94cacba
Compare
Jesse205
force-pushed
the
fix/transition-appear
branch
from
94cacba to
a3b97f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug that when the
appearattribute ofFadeandSlidewasfalse, the animation would still be played when the component was mounted for the first timeI also fixed a bug where
Drawerwould play animations when it was first mounted.In MUI, theslidingDraweris loaded and then added to theRootSlot, but not in Solidjs, where you need to wait for the child component to call children before the component can be mounted.(Or I don't know any other way.) So I givesetMounted(true);requestAnimationFramehas been added so that it is 'mounted' after the child component is mounted.