feat: confirm on bulk rename #2704
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the PR, but the bulk renaming deliberately doesn't use the confirm component, see #2246 (comment). Could you explain how this PR addresses the problems I mentioned in that issue? |
|
It needs a new PR. Confirm component wouldn't be a question anymore if yazi could copy items easily like terminal. For example, interacting with failed tasks like interacting normal files in yazi. |
sxyazi
requested changes
May 1, 2025
There was a problem hiding this comment.
Please format the code as per https://github.com/sxyazi/yazi/blob/main/CONTRIBUTING.md#development-setup
sxyazi
reviewed
May 1, 2025
Comment on lines
-104
to
-108
| if !succeeded.is_empty() { | ||
| Pubsub::pub_from_bulk(succeeded.iter().map(|(o, n)| (o, &n.url)).collect()); | ||
| FilesOp::rename(succeeded); | ||
| } | ||
| drop(permit); |
There was a problem hiding this comment.
It's my fault. Let me add it back.
There was a problem hiding this comment.
I'm not familiar with the pubsub api so I didn't reuse BodyBulk in Pump::serve. Any suggestions?
sxyazi
force-pushed
the
main
branch
3 times, most recently
from
d1efbb8 to
a0ab614
Compare
sxyazi
force-pushed
the
main
branch
4 times, most recently
from
35d9907 to
2768fd2
Compare
sxyazi
force-pushed
the
main
branch
3 times, most recently
from
9f077f9 to
60a2382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.