Make sure locale doesn't change after flush is called

[wouterj]

Fixes #145

I could not find an easy way to test this...

[dbu]

you should use $uow->getDocumentId($document) instead. reading the $meta->getIdentifierValue code, it seems that the id could be not mapped on the document.

[wouterj]

Thanks, didn't know such a method existed on the uow.

[dbu]

as with the method to determine the locale, we where pondering to expose it in the document manager as well, to make it more "official"

[dantleech]

+1 nice work @wouterj -- whats the problem with testing? too much to setup?

[wouterj]

Added a test & fixed the comments.

@dantleech couldn't think of a way to bind different locales and then make sure the locale is not the last bound locale before calling flush. Now I realized it's just as simple as calling findTranslation before flushing...

[dbu]

this does nothing, its overwritten in the next iteration.

[dbu]

not sure what exactly causes the test failure - looks unrelated to this PR. the php class is Nodename not NodeName - is that case sensitive?

[wouterj]

Updated

[dantleech]

Tests failing, unidentified index path

[wouterj]

@dantleech this seems to be a bug in Doctrine PHPCR, when calling findTranslation before flush (it works before 1.2.0-RC4 btw).

This PR works perfectly, but the test doesn't. Should be skip it until the bug has been fixed, so we can merge this?

[dantleech]

It depends if we are going to release CMF before PHPCR-ODM 1.3. If we have found a regression it must be fixed before the 1.3 release. If we plan to release 1.3 before or at the same time as the next CMF round of releases, I would prefer to wait.

Could you create an issue on phpcr-odm? If nobody else looks I will try and tackle it on Saturday

[dbu]

phpcr-odm 1.3 is at RC2, i would hope we can release that very soon and before the cmf release.

[wouterj]

Build passes now, thanks @dantleech

[dbu]

so, should we merge this? or is doctrine/phpcr-odm#665 still a problem?

[wouterj]

No, @dantleech worked around that bug in the tests.

[dantleech]

Cheers @wouterj