Skip to content

Conversation

@Guikingone
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues None
License MIT

Hi 👋🏻

Here's the PR for the support of Cartesia as a TTS / STT platform.

@Guikingone
Copy link
Contributor Author

Guikingone commented Oct 29, 2025

Unpopular opinion to discuss @OskarStark @chr-hertel but IMHO, the CI should not fail if we're using readonly classes.

Small example with the Symfony\AI\Platform\Contract defined as readonly, if I remove the readonly from sub-classes, PHP will throw an error.

Using readonly is not a bad approach IMHO, what's the goal behind this restriction? 🤔

PS: There's little to no chance that one day, we store informations in the *Client classes.

@chr-hertel
Copy link
Member

I don't think that this is an unpopular opinion, it's just something that is not easy to have while having to keep up with the BC promise, see symfony/symfony#62168 (comment) for reasoning.

@Guikingone Guikingone marked this pull request as ready for review November 3, 2025 12:38
@carsonbot carsonbot added Feature New feature Platform Issues & PRs about the AI Platform component labels Nov 3, 2025
@Guikingone Guikingone requested a review from chr-hertel November 3, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature Platform Issues & PRs about the AI Platform component Status: Needs Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants