Skip to content

Conversation

@dbu
Copy link
Contributor

@dbu dbu commented Aug 4, 2025

workaround for #94

until #94 is cleanly solved, this would allow to install mercure-bundle and symfony/ux-turbo in their latest versions.

i see that ux-turbo does provide a RegisterMercureHubsPass so maybe the proper solution here would be to just remove this service definition (and declare a conflict with symfony/ux-turbo versions that do not have that compiler pass)

@chalasr
Copy link
Member

chalasr commented Aug 4, 2025

Adding $twig as non-optional parameter is a BC break in ux-turbo though, introduced in symfony/ux#2447

@dbu
Copy link
Contributor Author

dbu commented Aug 5, 2025

Adding $twig as non-optional parameter is a BC break in ux-turbo though, introduced in symfony/ux#2447

yes.
but its been there for several patch versions now, so i don't expect it to be reverted again, that would create a new mess.

@dbu
Copy link
Contributor Author

dbu commented Aug 5, 2025

build failure is not related to the changes in this bundle. symfony/mercure claims to be compatible with PHP 7 but its own tests fail

@dunglas dunglas merged commit a931134 into symfony:main Nov 20, 2025
2 of 20 checks passed
@dunglas
Copy link
Member

dunglas commented Nov 20, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants