🐛 Gracefully handle invalid dates#26
Closed
homersimpsons wants to merge 1 commit intosymfony:7.1from
homersimpsons:patch-1
Closed
🐛 Gracefully handle invalid dates#26homersimpsons wants to merge 1 commit intosymfony:7.1from homersimpsons:patch-1
homersimpsons wants to merge 1 commit intosymfony:7.1from
homersimpsons:patch-1
Conversation
Contributor
Author
|
I should create this Pull Request in symfony/symfony. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(found in symfony-tools/docs-builder#179)
When parsing the following yaml:
symfony/yamlwill throw an exception:This is because the "month" is invalid. Fixing the "month" will trigger about the same issue because the "day" would be invalid.
With the current change it will gracefully handle the value as a string: