Fix code issues: namespace comment and Windows DLL export#2
Open
hobostay wants to merge 2 commits intosymisc:mainfrom
Open
Fix code issues: namespace comment and Windows DLL export#2hobostay wants to merge 2 commits intosymisc:mainfrom
hobostay wants to merge 2 commits intosymisc:mainfrom
Conversation
The `// namespace` comment was placed after the `printShape` function closing brace instead of the actual anonymous namespace closing brace. This has been corrected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When building as a shared library on Windows, enable automatic symbol export via CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS. This prevents linker errors when using the library as a DLL on Windows platforms. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two code issues found in the codebase:
Fix incorrect namespace comment placement in example.cpp
// namespacecomment was placed after theprintShapefunction closing brace instead of the actual anonymous namespace closing brace.Add Windows shared library symbol export support
CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS.Test plan
Files changed
example.cpp: Fixed namespace comment placementCMakeLists.txt: Added Windows DLL export support🤖 Generated with Claude Code