-
Notifications
You must be signed in to change notification settings - Fork 2
feat(extension): add update/install and cargo-e sync functionality #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,6 +27,14 @@ | |
| { | ||
| "command": "multiBuild.showRoomId", | ||
| "title": "Multi-Build: Show/Edit Room ID" | ||
| }, | ||
| { | ||
| "command": "multiBuild.updateAndInstall", | ||
| "title": "Multi-Build: Update, Package, and Install Extension" | ||
| }, | ||
| { | ||
| "command": "multiBuild.broadcastUpdateAndInstall", | ||
| "title": "Multi-Build: Broadcast Update/Install to All Machines" | ||
|
Comment on lines
+31
to
+37
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm curious about these. What is the idea behind them?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't want to have to vsce package install manually on my local machine and across the other machines. I modified sync to support vsce package.json detection at the top level. so you can sync inside multi-build and it will detect the vsce and install it and reload the window, and post the message to reload the window...so that the other code windows open on the machine update their running plugin. the multiBuild.updateAndInstall is a direct way to do it without the prompts and not via a sync. multiBuild.broadcastUpdateAndInstall is the same idea, a way to directly broadcast to everyone that they should pull, package, and install. they are implemented with the terminal and have timeouts and it bothers me; using direct invocation didn't provide any feedback so I think a timeout is OK and I guess I adjust it as runtime changes. I will get to this as soon as I can; I'm trying to solve another issue and I can't put it down quite yet. If you get to this before I do, welcome to change it to suite your preferences. I like the statubar version being there. I would like it to allow you to disconnect/disable/configure the plugin too.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm trying to understand the rationale of developing through packaged versions, rather than running through the dev env on each machine. Normally when developing an extension you'd open the extension project in VS Code run However, [and I think this is a different problem that looks similar] outside of development, when transitioning back to being a user, I am finding it quite painful switching to the release version of the extension as it then has to be manually installed on each computer (as it's not on the marketplace yet). However, this problem is already solved by the VS Code Extension Marketplace and syncing your configs through Settings Sync. Edit: Related to #28
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When developing the extension; being able to sync and build and install across all the machines is very helpful. I made sync support this, I added a local only method, and I am still trying to make other top level commands. i.e. the reload window functionality I was trying to find. If this doesn't go that's fine, but it was a serious help in testing the extension across my machines. |
||
| } | ||
| ], | ||
| "configuration": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in: