Implement custom currency symbol/abbreviation (resolves issue #7) #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxuser
changed the title
Contributor
|
This is a great start. A few quick thoughts. You can make make a multi question survey instead of repeatedly invoking AskOne. I recommend treating the currency symbol as a const and passing it in separately instead of making it part of the data struct, since it doesn't get updated regularly. |
…Viper.GetString('currencySymbol') over and over
Contributor
Author
|
Feedback incorporated |
Contributor
|
Hey, @tuxuser. I promise I'll get to this. I've been slammed due to some personal stuff. Thank you so much for your contributions and your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to set custom currency symbol or abbreviation via
setsubcommand / cfg file.