-
Notifications
You must be signed in to change notification settings - Fork 22
981174: Add Grid with AI Assist view sample #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| const toolbarOptions: object[] = [{ tooltipText: 'AI Assist', prefixIcon: 'e-assistview-icon', id: 'ai-assist-btn', align: 'Left' }]; | ||
|
|
||
| // Handles the Grid toolbar button click action. If the AI Assist button clicked shows the AI Assist dialog. | ||
| const toolbarClick = (args: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use any type here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to use any bcoz of eventTarget possibly null.
|
|
||
| // Handles prompt request execution. | ||
| const onPromptRequest = (args: PromptRequestEventArgs) => { | ||
| (assistView as any).stopResponding.classList.remove('e-btn-active'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use any here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use any type here bcoz of accessing the private method
rajapandiyan-settu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provide a proper PR template for this implementation
Bug description
Need to add more sample with ai grid and planned for sp release.
Root cause
Added new sample
Reason for not identifying earlier
Find how it was missed in our earlier testing and development by analyzing the below checklist. This will help prevent similar mistakes in the future.
Guidelines/documents are not followed
Common guidelines / Core team guideline
Specification document
Requirement document
Guidelines/documents are not given
Common guidelines / Core team guideline
Specification document
Requirement document
Reason:
NA
Action taken:
SB automation has been covered in this case.
Related areas:
Sorting, Alignment, Touch, RTL, resizing
Is it a breaking issue?
No.
Solution description
Get response from open ai to generate query for data operation and assigned to grid query.
Output screenshots
NA.
Areas affected and ensured
NA.
Additional checklist
This may vary for different teams or products. Check with your scrum masters.
Did you run the automation against your fix? - No.
Is there any API name change? - No
Is there any existing behavior change of other features due to this code change? - No
Does your new code introduce new warnings or binding errors? - No
Does your code pass all FxCop and StyleCop rules? a- No
Did you record this case in the unit test or UI test? - No.