Feature: add bracket share link to mastodon#70
Open
edm00se wants to merge 4 commits intosyntaxfm:mainfrom
Open
Feature: add bracket share link to mastodon#70edm00se wants to merge 4 commits intosyntaxfm:mainfrom
edm00se wants to merge 4 commits intosyntaxfm:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was sad to not see the mastodon share button next to 🚌🔑 or at xitter (or whatever the raging birds app is called now). Thankfully Mastodon recently announced their new share button, so all it would need is a fancy looking hyperlink.
I believe I hand jammed this all correctly, but I might have to ask a clanker. I prepared it then did some dev tools editing to make sure it looked right, including the svg; that might be able to be optimized a little but works on my machine.
Speaking of:
the button forced in place via dev tools hackery
the button flow in action
I did this in browser dev tools from the live site since I didn't quite feel like starting up a cloudflare db and gh secrets to test the visual change.
I love synatx and the site and I'm looking forward to seeing how this all plays out.