🐛 Fix duplicate volumeMounts in hcloud-csi controller#118
Open
🐛 Fix duplicate volumeMounts in hcloud-csi controller#118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
volumeMountskey from thehcloud-csi-drivercontainer incharts/hcloud-csi/templates/controller/deployment.yaml1.3.1Why
The template currently renders
volumeMountstwice in the same YAML mapping for thehcloud-csi-drivercontainer. Helm will still render the manifest, but strict YAML consumers reject it as invalid due to the duplicate key.This showed up downstream when rendering the chart and passing the result to a YAML parser:
The later
volumeMountsblock is already the complete one because it also appendscontroller.extraVolumeMounts, so removing the earlier block is the minimal fix.Validation
helm template test charts/hcloud-csi > /tmp/hcloud-csi-template.yaml/tmp/hcloud-csi-template.yamlsuccessfully with PyYAML