Deny process_vm_readv in BPF filter from guest#47
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The guest runs as a child of the supervisor under the same UID, so process_vm_readv would succeed without a seccomp deny. The supervisor uses process_vm_readv on the child, not the reverse; the child has no legitimate use for it. Add NR 310 (x86_64) and NR 270 (aarch64) to the deny list alongside the existing process_vm_writev entries. Change-Id: I9627c19c00750783fbf3da787b6c71be0a8876eb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guest runs as a child of the supervisor under the same UID, so process_vm_readv would succeed without a seccomp deny. The supervisor uses process_vm_readv on the child, not the reverse; the child has no legitimate use for it. Add NR 310 (x86_64) and NR 270 (aarch64) to the deny list alongside the existing process_vm_writev entries.
Change-Id: I9627c19c00750783fbf3da787b6c71be0a8876eb
Summary by cubic
Block process_vm_readv in the guest with a seccomp BPF deny to prevent cross-process memory reads.
process_vm_readv(NR 310 on x86_64, NR 270 on aarch64) alongsideprocess_vm_writev.process-vm-deny-testand run it viascripts/run-tests.sh.Written for commit 00000b5. Summary will update on new commits.