refactor: occupation and occupation group cleanups#486
Merged
irumvanselme merged 1 commit intomainfrom Mar 30, 2026
Merged
Conversation
df024b2 to
5453704
Compare
Comment on lines
949
to
955
| * | ||
| * /models/{modelId}/occupations/{id}/skills: | ||
| * get: | ||
| * operationId: GETOccupationSkills | ||
| * operationId: GETkills | ||
| * tags: | ||
| * - occupations | ||
| * summary: Get the skills of an occupation. |
There was a problem hiding this comment.
Bug: A typo in the JSDoc operationId for getSkills (GETkills instead of GETOccupationSkills) causes a broken schema reference in the generated OpenAPI documentation.
Severity: MEDIUM
Suggested Fix
Correct the typo in the JSDoc comment in backend/src/esco/occupations/index.ts. Change the operationId from GETkills back to GETOccupationSkills and update the corresponding error schema reference from GETkills404ErrorSchema to GETOccupationSkills404ErrorSchema to match the definition in the OpenAPI generator.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: backend/src/esco/occupations/index.ts#L949-L955
Potential issue: In the `getSkills` method's JSDoc comments, the `operationId` was
changed to `GETkills` and the corresponding schema reference was updated to
`GETkills404ErrorSchema`. However, the OpenAPI schema registration in
`backend/openapi/generateOpenApiDoc.ts` still defines the schema as
`GETOccupationSkills404ErrorSchema`. This mismatch creates a broken `$ref` in the
generated OpenAPI specification, as it points to a schema that does not exist. While
this does not cause a runtime server error, it breaks OpenAPI specification validation
and can cause failures in API documentation and client generation tools that depend on a
valid schema.
Did we get this right? 👍 / 👎 to inform future reviews.
… & Occupation Group
5453704 to
78b9b1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.