Bump Vitest to v4 #19216
Draft
Bump Vitest to v4 #19216
+199
−487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we just repeat a step and create the shards dynamically, but not sure if that's even possible. With this approach, we will generate _a lot_ more integration tests though...
|
The Vitest tests timeout because of the repeated design system reloading + canonicalization cache prefilling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps Vitest from v2 to v4. As far as I know we don't use any Vitest specific features in our tests, but had to upgrade the
vitest.workspace.tsfile to avitest.config.tsfile instead.The only features we use are the typical
describe,it,test, andexpectfunctions.The only other part we use is
vi.spyOnandvi.fnbut those didn't change in API either.Test plan
Enabling [ci-all], to make sure all tests pass on all platforms.