chore: remove duplicate esbuild devDependencies #19499
Open
+340
−904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnpm has got itself in a state it can't seem to get out of. basically, it has 3 versions of esbuild install (0.23.x, 0.27.x, 0.25.x) thanks to the fact we have `tsx` installed. we don't depend on `tsx` anywhere, nor do any dependencies in the entire tree. pnpm is holding onto it for no reason. it is an _optional_ peer of vite and postcss-load-config (via tsup), one which we don't depend on anywhere and so it shouldn't be installed. I tried many different pnpm commands, configs, etc. Nothing seems to get pnpm to behave here. **Removing the lockfile entirely does solve the problem.** It does mean some dependencies were upgraded, but mostly just esbuild patches and what not.
43081j
changed the title
43081j
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm has got itself in a state it can't seem to get out of.
basically, it has 3 versions of esbuild install (0.23.x, 0.27.x, 0.25.x)
thanks to the fact we have
tsxinstalled.we don't depend on
tsxanywhere, nor do any dependencies in the entiretree. pnpm is holding onto it for no reason.
it is an optional peer of vite and postcss-load-config (via tsup), one
which we don't depend on anywhere and so it shouldn't be installed.
to fix this, i did a bunch of pnpm-fu to remove and re-add the target packages, and it now seems to have cleaned up the duplicates.
At some point, we should probably just remove the lock file and re-generate it. I think there'll be many other cases like this.
Test plan
Existing tests should cover this.