Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis change updates the 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/@tailwindcss-upgrade/package.json (1)
34-34: Verify file discovery behavior in monorepo scenarios withglobbyv16.
globbyv16 changes howgitignore: trueresolves parent.gitignorefiles—it now searches up to the Git repository root. This code already acknowledges this at Line 103 with a comment, but there are no dedicated tests validating file discovery behavior in nested/monorepocwdcases. Consider adding a test to ensure CSS files are discovered as expected when the tool runs from a subdirectory within a monorepo.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/`@tailwindcss-upgrade/package.json at line 34, Add a unit/integration test that verifies file discovery when running from a nested cwd in a monorepo with globby v16: create a test (e.g., discoverCssFilesInMonorepo or findFilesFromNestedCwd) that sets up a repo-like fixture with a parent .gitignore and CSS files at different levels, run the module function that uses globby (the code path that constructs the globby call) with gitignore: true and cwd pointed to a subdirectory, and assert that the expected CSS files are returned; this ensures the code that calls globby (the file-discovery logic) behaves correctly with globby v16’s upward .gitignore resolution.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/`@tailwindcss-upgrade/package.json:
- Line 34: Add a unit/integration test that verifies file discovery when running
from a nested cwd in a monorepo with globby v16: create a test (e.g.,
discoverCssFilesInMonorepo or findFilesFromNestedCwd) that sets up a repo-like
fixture with a parent .gitignore and CSS files at different levels, run the
module function that uses globby (the code path that constructs the globby call)
with gitignore: true and cwd pointed to a subdirectory, and assert that the
expected CSS files are returned; this ensures the code that calls globby (the
file-discovery logic) behaves correctly with globby v16’s upward .gitignore
resolution.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 783ba83b-314a-479d-aa65-f0de6a2cd914
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
packages/@tailwindcss-upgrade/package.json
|
@depfu rebase |
depfu
bot
force-pushed
the
depfu/update/pnpm/globby-16.2.0
branch
from
6ccedca to
8d3db05
Compare
1 participant
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ globby (15.0.0 → 16.2.0) · Repo
Release Notes
16.2.0
16.1.1
16.1.0
16.0.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 30 commits:
16.2.0Add `globalGitignore` optionFix CI16.1.1Fix negation patterns with absolute filesystem paths16.1.0Add `expandNegationOnlyPatterns` optionFix: Normalize leading-slash negation patterns before task generation16.0.0Fix bundler compatibilityRespect parent .gitignore files when `gitignore` option is enabledAdd test for `suppressErrors` option with file patternsAdd test for ignore option with trailing slashesFix parent directory patterns with `gitignore` optionAdd tests for special characters in directory namesImprove path check in gitignore logicImprove error message for invalid `cwd` optionFix types for `stats` optionFix ignore patterns with parent directory referencesImprove Windows path documentationSupport negation-only patternsRespect custom fs implementation from optionsImprove docs for `convertPathToPattern`Add test for .npmignore in subdirectoriesClarify `gitignore` priority in documentationAdd test for nested gitignore with negationAdd some more options to isGitIgnored functionsFix `{gitignore: true}` performance issueAdd tests for some fast-glob limitationsAdd test for gitignore patterns starting with `./` or `../`Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands