added errors for every request to RollongCurl#3
Open
thlib wants to merge 1 commit intotakinbo:masterfrom
thlib:patch-2
Open
added errors for every request to RollongCurl#3thlib wants to merge 1 commit intotakinbo:masterfrom thlib:patch-2
thlib wants to merge 1 commit intotakinbo:masterfrom
thlib:patch-2
Conversation
It is not documented but sometimes curl_getinfo returns 0. According to user comments this means that the host was not found, according to my test it seems to be true, so I added support for that. Also sometimes an individual request would be downloaded halfway but still appear as if it was successfully downloaded, this can be checked by comparing the value in $done['result'], documentation on PHP http://www.php.net//manual/en/curl.constants.php and http://curl.haxx.se/libcurl/c/libcurl-errors.html older versions of PHP do not support curl_strerror so I added curl_multi_strerror instead, the user is free to check for the error using curl_strerror in the callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not documented but sometimes curl_getinfo returns 0.
According to user comments this means that the host was not found, according to my test it seems to be true, so I added support for that.
Also sometimes an individual request would be downloaded halfway but still appear as if it was successfully downloaded, this can be checked by comparing the value in $done['result'], documentation on PHP http://www.php.net//manual/en/curl.constants.php and http://curl.haxx.se/libcurl/c/libcurl-errors.html older versions of PHP do not support curl_strerror so I added curl_multi_strerror instead, the user is free to check for the error using curl_strerror in the callback