Ported converters to use stock generators resubmission#2
Open
seanth wants to merge 5 commits intotaniwha:masterfrom
Open
Ported converters to use stock generators resubmission#2seanth wants to merge 5 commits intotaniwha:masterfrom
seanth wants to merge 5 commits intotaniwha:masterfrom
Conversation
Set up the converters to use the stock moduleresourceconverter
The chemistry is not realistic at all, but the reactions are mass balanced. See following for maths: https://docs.google.com/spreadsheets/d/11H1hLzPzBl2pBNYymQwinJCxgsket9GI GNfUSgvfn1g/edit?usp=sharing
merge remote tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated from rebase to taniwha/Kethane
Ported the kethane converters to use the stock moduleResourceConverter. This should allow background processing.
This mass balances the converters. The math is at https://docs.google.com/spreadsheets/d/11H1hLzPzBl2pBNYymQwinJCxgsket9GIGNfUSgvfn1g/edit?usp=sharing
The basic problem is that the kethane resource, though modeled after methane, can't magically generate oxygens and xenon in reactions. I have it mass balanced, so the craft won't gain or lose mass as conversions happen, but there is some magical alchemy going on.