feat: add option to force change default password

[localvar]

Description

add option to force change default password.

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @localvar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a new build-time configuration option that provides greater control over the security posture of newly created default user accounts. It allows administrators to decide whether these users are immediately prompted to change their initial password, thereby enhancing flexibility in enforcing password policies.

Highlights

• New Build Option for Default Passwords: Introduced a new CMake option, ALLOW_DEFAULT_PASSWORD, which controls whether the system defines TD_ALLOW_DEFAULT_PASSWORD during compilation. By default, this option is set to 'true'.
• Conditional Default Password Enforcement: Modified the user creation logic in mndCreateDefaultUser to conditionally set the changePass property for new default users. If TD_ALLOW_DEFAULT_PASSWORD is defined (the default behavior), users are not forced to change their password immediately. Otherwise, they are required to change it upon first login.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new build option, ALLOW_DEFAULT_PASSWORD, to control whether the default user is forced to change their password upon first login. The implementation correctly uses this option to set the changePass flag. My review includes a suggestion to improve the CMake script by using the idiomatic OPTION command for better robustness and clarity. Additionally, I recommend replacing the magic numbers for the changePass flag with either named constants or at least comments to enhance code readability.

[Copilot]

Pull request overview

This PR adds a compile-time configuration option to control whether default users must change their password on first login. When ALLOW_DEFAULT_PASSWORD is set to "false" (via CMake), default users will be required to change their password (changePass=1). The default behavior (when set to "true") allows users to keep the default password (changePass=2).

Key changes:

• Added CMake variable ALLOW_DEFAULT_PASSWORD (defaults to "true") that defines the TD_ALLOW_DEFAULT_PASSWORD macro
• Modified default user creation logic to conditionally set changePass field based on the compile-time flag

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
cmake/define.cmake	Adds ALLOW_DEFAULT_PASSWORD configuration option (defaults to "true") and defines TD_ALLOW_DEFAULT_PASSWORD macro when enabled
source/dnode/mnode/impl/src/mndUser.c	Wraps changePass field assignment in conditional compilation to set value to 2 (allow default password) when TD_ALLOW_DEFAULT_PASSWORD is defined, or 1 (force password change) otherwise

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.