fix(stream/fetch): fix stream data fetching from runner

[stephenkgu]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @stephenkgu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issues related to stream data fetching and external window aggregation. It refines the serialization process for stream pseudo-function data to ensure consistent behavior, and corrects the state management within the external window operator to prevent logical errors when processing aggregated results. These changes collectively aim to stabilize data streaming and aggregation functionalities.

Highlights

• Stream Data Serialization Fix: Modified the serialization logic for stream pseudo-function information by commenting out a condition (pReq->reset &&), ensuring needStreamPesudoFuncVals is always considered. This likely addresses an issue where stream data was not being fetched correctly from the runner under certain reset conditions.
• External Window Aggregation Logic Correction: Improved the external window aggregation output mechanism by ensuring the outputWinId is correctly incremented when the output threshold is met, preventing potential infinite loops or incorrect state in subsequent calls. Also, a minor stylistic change from post-increment to pre-increment for outputWinId in a loop.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces fixes for stream data fetching. One change in tmsg.c modifies the serialization logic for SResFetchReq by altering the condition for serializing StRtFuncInfo. Another change in externalwindowoperator.c corrects the window ID increment logic within extWinAggOutputRes to prevent potential infinite loops when an output block is full. My review focuses on code maintainability. I've suggested removing commented-out code to improve clarity.