-
Notifications
You must be signed in to change notification settings - Fork 5k
fix: correct syntax for checking existence of docs-c-test log file #34191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @tomchon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request intends to expand the CI pipeline's log collection by adding a mechanism to detect and archive the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to add a check for a C example log file and copy it if it exists. However, the implementation has a syntax error in the shell if condition. A space is missing after the opening bracket [, which will cause the script to fail. I've provided a comment with a suggested fix to correct the syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to add a check for the existence of a C test log file and copy it to the appropriate directory, similar to the existing Java log file handling. However, the implementation contains a critical syntax error that prevents the script from executing correctly.
- Adds conditional check and copy operation for
docs-c-test-out.logfrom C examples directory
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: WANG Xu <feici02@outlook.com>
No description provided.