fix(client): heartbeat msg incompatible

[wangmm0220]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link
• https://project.feishu.cn/taosdata_td/defect/detail/6664967848

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @wangmm0220, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical incompatibility issue in heartbeat message processing. By introducing client version awareness into the deserialization logic, the system can now correctly interpret and process heartbeat requests from both older and newer client versions. This change ensures robust communication and prevents deserialization failures that could arise from variations in message structure across different client releases.

Highlights

• Version-Aware Deserialization: Heartbeat message deserialization now explicitly considers the client's version to ensure compatibility with different client message formats.
• Conditional Field Parsing: The sVer and cInfo fields within SClientHbReq are now conditionally deserialized only if the client version is 3.3.6.31 or newer, preventing errors with older clients that may not send these fields.
• API Updates: The tDeserializeSClientHbReq and tDeserializeSClientHbBatchReq functions have been updated to accept a clientVersion parameter, which is then utilized in the deserialization logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a client heartbeat message incompatibility by introducing version-based deserialization. The changes correctly add a clientVersion parameter to deserialization functions and use it to conditionally parse fields, which should resolve the incompatibility with older clients. My main feedback is to optimize the version check by replacing the repeated taosVersionStrToInt call with a pre-calculated constant. This will improve performance and remove a magic string from the code.

[Copilot]

Pull request overview

This PR fixes a heartbeat message incompatibility issue by adding client version-based conditional deserialization for fields introduced in version 3.3.6.31. The changes enable the server to handle heartbeat messages from both older clients (< 3.3.6.31) that don't include sVer and cInfo fields, and newer clients that do.

• Added clientVersion parameter to heartbeat deserialization functions to support version-aware parsing
• Implemented conditional deserialization of sVer and cInfo fields based on client version >= 3.3.6.31
• Updated function signatures to thread client version through the deserialization call stack

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
source/common/src/msg/tmsg.c	Added client version parameter to deserialization functions and implemented version check logic to conditionally deserialize sVer/cInfo fields; added tversion.h include
include/common/tmsg.h	Updated function signature to include clientVersion parameter
source/dnode/mnode/impl/src/mndProfile.c	Passed client version from RPC message info to deserialization function

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.