fix(client): heartbeat msg incompatible

[wangmm0220]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link
• https://project.feishu.cn/taosdata_td/defect/detail/6664967848

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @wangmm0220, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an incompatibility issue with client heartbeat messages by implementing version-aware deserialization. It modifies the heartbeat message processing to dynamically handle different client versions, specifically by conditionally decoding certain fields based on the client's reported version. This change ensures that the system can maintain robust communication with both older and newer clients, preventing parsing errors and improving overall stability of the heartbeat mechanism.

Highlights

• Heartbeat Deserialization Update: The tDeserializeSClientHbBatchReq and tDeserializeSClientHbReq functions have been updated to accept a clientVersion parameter, enabling version-aware processing of heartbeat messages.
• Conditional Field Decoding: Introduced logic to conditionally decode sVer and cInfo fields within SClientHbReq based on the clientVersion. These fields are now only processed if the client version is 3.3.8.5 or newer, ensuring backward compatibility.
• Client Version Integration: The mndProcessHeartBeatReq function in the dnode now passes the client's version (pReq->info.cliVer) to the heartbeat deserialization functions, allowing the server to adapt to different client message formats.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a backward compatibility issue with client heartbeat messages by conditionally deserializing fields based on the client version. The changes are logical and correctly implemented. I have one suggestion to improve performance by caching the result of a version string conversion, which is currently performed repeatedly within a loop.

[Copilot]

Pull request overview

This PR fixes a heartbeat message incompatibility issue between different client and server versions. The fix adds client version information to the deserialization process, allowing the server to correctly handle heartbeat messages from clients running different versions.

• Added clientVersion parameter to tDeserializeSClientHbBatchReq and tDeserializeSClientHbReq functions
• Implemented version-based conditional deserialization for sVer and cInfo fields (only for clients >= 3.3.8.5)
• Updated the heartbeat request handler in mnode to pass client version information

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
include/common/tmsg.h	Updated function signature for tDeserializeSClientHbBatchReq to accept client version parameter
source/common/src/msg/tmsg.c	Modified deserialization functions to conditionally deserialize version-specific fields based on client version; added version check logic for 3.3.8.5
source/dnode/mnode/impl/src/mndProfile.c	Updated heartbeat handler to pass client version when deserializing heartbeat batch requests

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.