Open
Conversation
Old code was getting really messy. Everything didn't have any cohesion at all. Thinking of creating the GUI system first then injecting the canvas onto it to see how it goes.
Not very well-implemented. Points of improvement: 1. Scroll doesn't account for offset positioning 2. Scroll offsets the entire box's position, it should offset child elements nested within. 3. No proper propagation downwards. Scrolling seems to affect the whole parent box..
Now it doesn't offset the entire box, just the widgets inside (Button for now). However, it can clip overflowing widget at the bottom, but not at the top because I am drawing from top down/left right and applying a clear over the remaining space before drawing subsequent elements.
Discovered that there is a SetClipRectangle function that declares a bounding clip rectangle when drawing onto a surface. That solves the issue of overflow items in the rectangle. I can now remove the previous complex, buggy way of handling overflow (drawing blanks on the remaining space after drawing a box).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revamping the GUI