Open
Conversation
TimothyGu
force-pushed
the
master
branch
9 times, most recently
from
0914e3a to
580fb6a
Compare
TimothyGu
force-pushed
the
master
branch
14 times, most recently
from
b5aa514 to
30e2bb0
Compare
TimothyGu
force-pushed
the
master
branch
7 times, most recently
from
dd99d34 to
b8ede4d
Compare
Adapted from the corresponding me_cmp code. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Adapted from the corresponding me_cmp code. Only the width 16 function has been adapted, because it seems that the width 8 function actually reads 16 bytes per line. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
This improves the debugging experience. These are all internal structs so there is no need to worry about ABI stability as a result of adding flags. Signed-off-by: Niklas Haas <git@haasn.dev>
Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
Using the new ff_sws_op_type_name() helper. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
I think this just makes for a marginally nicer debugging experience. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
op->rw.frac dereferences nonsense on clear ops. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
…ation Rather than testing for it separately for some reason. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
And call it on the read/write ops directly, rather than this awkward loop. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
This is already called by compile_backend(), and nothing else in this file depends on accurate values. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
Instead of once at the start of add_convert_pass(). This makes much more sense in light of the fact that we want to start e.g. splitting passes apart. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
Instead of optimizing it with an explicit call. May enable more optimizations in the future. Signed-off-by: Niklas Haas <git@haasn.dev>
This should match the number of lines. As an aside, align these declarations. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
Results in IMHO slightly more readable code flow, and will be useful in an upcoming commit (that adds logic to ref individual planes). Signed-off-by: Niklas Haas <git@haasn.dev>
Before allocating/referencing buffers, make sure these fields are in a defined state. Signed-off-by: Niklas Haas <git@haasn.dev>
This array is defined as contiguous. Signed-off-by: Niklas Haas <git@haasn.dev>
And call it on the read/write ops directly, rather than this awkward loop. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
This condition was weaker than necessary. In particular, graph->num_thread == 1 guarantees pass->num_slices == 1. Signed-off-by: Niklas Haas <git@haasn.dev>
This name is weirdly out-of-place in the libswscale naming convention. Signed-off-by: Niklas Haas <git@haasn.dev>
Signed-off-by: Niklas Haas <git@haasn.dev>
This is just slightly common enough a pattern that it IMO makes sense to do so. This will also make more sense after the following commits. Signed-off-by: Niklas Haas <git@haasn.dev>
This is arguably more convenient for most downstream users, as will be more prominently seen in the next commit. Also allows this code to re-use a pass_free() helper with the graph uninit. Signed-off-by: Niklas Haas <git@haasn.dev>
Now that this function returns a status code and takes care of cleanup on failure, many call-sites can just return the function directly. Signed-off-by: Niklas Haas <git@haasn.dev>
Allows compiled functions to opt out of the ops_dispatch execution harness altogether and just get dispatched directly as the pass run() function. Useful in particular for Vulkan. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
Avoids some unnecessary round-trips through the execution harness, as well as removing one unnecessary layer of abstraction (SwsOpExec). It's a bit unfortunate that we have to cast away the const on the AVFrame, since the Vulkan functions take non-const everywhere, even though all they're doing is modifying frame internal metadata, but alas. Sponsored-by: Sovereign Tech Fund Signed-off-by: Niklas Haas <git@haasn.dev>
These were abstraction-violating in the first place. Good riddance. This partially reverts commit c911295. Signed-off-by: Niklas Haas <git@haasn.dev>
fixup 08d327e When an uchar is set to -1, it will become 255 when read as an int. Duplicate variables for two terminal types can also avoid unused variable warnings. Signed-off-by: nyanmisaka <nst799610810@gmail.com>
Added in e995cf1, yet this filter does not have any dsp function using MMX: it only has generic x86 assembly, no SIMD at all, so this emms_c() was always unnecessary. Reviewed-by: Kacper Michajłow <kasper93@gmail.com> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Based on 248b481 Signed-off-by: James Almer <jamrial@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.