Drop tests for plural categories of scientific & engineering notation #4803
+1
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #4503 added tests that include the expected plural categorization of values that are formatted as "1E6", "1,5E6", and "1E-6" in French. These tests should be dropped, because no data exists on the actually appropriate plural categorization of values with exponential notation; see for instance the CLDR instructions for determining a language's plural rules, which make no mention of exponential notation.
The values currently in the test are likely whatever ICU4C produces for exponential notation, but those are effectively random; see for instance how the plural category of "1E-6" is expected to be
many, which makes no sense.CC @anba, @ryzokuken