[Temporal] Add coverage for non-string month codes in from methods
#4807
+96
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
requested changes
Jan 6, 2026
test/intl402/Temporal/PlainDate/prototype/monthCode/month-code-wrong-type.js
Outdated
Show resolved
Hide resolved
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| /*--- | ||
| esid: sec-temporal.plaindate.prototype.monthcode |
Contributor
There was a problem hiding this comment.
I don't think this is in the right place. It's a test for .from(), not date.monthCode, and I think it doesn't even need to be under intl402/
Add coverage for primitive non-string values passed in for the `monthCode` option in the `from` method for PlainDate, PlainDateTime, PlainYearMonth, and ZonedDateTime.
catamorphism
force-pushed
the
non-string-month-code
branch
from
a29e9a8 to
c9a69b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coverage for primitive non-string values passed in for the
monthCodeoption in thefrommethod for PlainDate, PlainDateTime, PlainYearMonth, and ZonedDateTime.