fix: Extend SupportedLanguages list based on languages listed in cards-database #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://github.com/tcgdex/cards-database/blob/master/server/compiler/index.ts Language "pt-pt" is completely empty and was not added. Is "pt-pt" equivalent to "pt"?
|
Beat me to it. I realized languages were out of sync. I think for now just merge these as is until a proper use-case is identified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript type
SupportedLanguageswas a bit out of sync with the languages available via the TCGdex API. Trying to use languages that are available but not defined in the type definition required type-checking opt-outs oras unknown as SupportedLanguagescasts.I updated the list with the languages defined here: https://github.com/tcgdex/cards-database/blob/master/server/compiler/index.ts
I did leave out
pt-ptas it is completely empty. (Is it equivalent to "pt", Portuguese (Portugal)?)Languages were sorted alphabetically but split between international and asia.
Maybe adding extra type definition for both those subsets that are then combined to
SupportedLanguagescould make sense but I don't see a use-case currently.What would make sense would be an export of the languages list in JavaScript to be able to iterate over all available languages. But maybe not providing this is also good to discourage the idea. :-)