Skip to content

fix: able rival list/#624#655

Merged
redjungi09 merged 1 commit intodevelopfrom
fix/able-rival-list/#624
Apr 8, 2026
Merged

fix: able rival list/#624#655
redjungi09 merged 1 commit intodevelopfrom
fix/able-rival-list/#624

Conversation

@hjbin-25
Copy link
Copy Markdown
Member

@hjbin-25 hjbin-25 commented Apr 8, 2026

변경사항

  • 라이벌 신청 가능 목록 조회 시 신청 불가 대상 제외 조건 추가
    • 내가 ACCEPTED 라이벌이 4명 이상인 경우 빈 목록 반환
    • 상대방이 ACCEPTED 라이벌이 4명 이상인 경우 목록에서 제외
  • 키워드 검색(SearchRivalByKeywordService)에서 PENDING 상태 라이벌을 제외하지 않던 버그 수정

관련 이슈

Closes #624

추가 컨텍스트

신청 가능 목록이지만 실제로 신청 시 ApplyRivalPolicy에서 거부되는 유저(라이벌 4명 초과, PENDING 중복)가 노출되는 문제를 사전에 필터링합니다.
상대방의 ACCEPTED 카운트는 후보 유저 목록을 먼저 조회한 뒤 countAcceptedByUserIdsGrouped로 배치 조회하여 N+1 없이 처리합니다.

@hjbin-25 hjbin-25 changed the base branch from main to develop April 8, 2026 14:22
@hjbin-25 hjbin-25 changed the title fix: 라이벌 신청 가능 목록에서 신청 불가 대상 제외 조건 추가 fix: able rival list/#624 Apr 8, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a maximum rival limit of four across the GetAllAbleRivalsService and SearchRivalByKeywordService. The services now verify the actor's current rival count and filter out potential candidates who have already reached the limit. Additionally, the search logic was refined to include status filtering and ensure distinct results. The review feedback recommends improving type safety by replacing manual map casting with typed projections or DTOs for repository results.

Copy link
Copy Markdown
Collaborator

@redjungi09 redjungi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redjungi09 redjungi09 merged commit e137d8c into develop Apr 8, 2026
1 check passed
@chaeyn chaeyn deleted the fix/able-rival-list/#624 branch April 9, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] 라이벌 3명인데 추가 신청 안됨

2 participants