Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a maximum rival limit of four across the GetAllAbleRivalsService and SearchRivalByKeywordService. The services now verify the actor's current rival count and filter out potential candidates who have already reached the limit. Additionally, the search logic was refined to include status filtering and ensure distinct results. The review feedback recommends improving type safety by replacing manual map casting with typed projections or DTOs for repository results.
.../java/com/process/clash/application/compete/rival/rival/service/GetAllAbleRivalsService.java
Show resolved
Hide resolved
...a/com/process/clash/application/compete/rival/rival/service/SearchRivalByKeywordService.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
SearchRivalByKeywordService)에서 PENDING 상태 라이벌을 제외하지 않던 버그 수정관련 이슈
Closes #624
추가 컨텍스트
신청 가능 목록이지만 실제로 신청 시
ApplyRivalPolicy에서 거부되는 유저(라이벌 4명 초과, PENDING 중복)가 노출되는 문제를 사전에 필터링합니다.상대방의 ACCEPTED 카운트는 후보 유저 목록을 먼저 조회한 뒤
countAcceptedByUserIdsGrouped로 배치 조회하여 N+1 없이 처리합니다.