Skip to content

Conversation

@jsoonworld
Copy link
Member

πŸ“„ Work Description

  • Spring Security 제거 및 μ»€μŠ€ν…€ 인증 체계 운영 μ„œλ²„ 적용

Feat : μ»€μŠ€ν…€ JWT Provider κ΅¬ν˜„
Feat : Interceptor 및 ArgumentResolver 기반 인증 λ§€μ»€λ‹ˆμ¦˜ κ΅¬ν˜„
Refactor : AuthService 둜직 톡합 및 λ¦¬νŒ©ν† λ§
Feat : μŠ€ν”„λ§ μ‹œνλ¦¬ν‹° μ˜μ‘΄μ„± 제거 및 μ»€μŠ€ν…€ 인증 μ „λ©΄ 적용
Refactor: JWT ν‚€ 생성 및 검증 λ‘œμ§μ„ 이전 λ°©μ‹μœΌλ‘œ λ‘€λ°±
[πŸ”€ merge] Spring Security 제거 및 μ»€μŠ€ν…€ 인증 체계 λ„μž…
@jsoonworld jsoonworld requested a review from Copilot July 15, 2025 02:37
@jsoonworld jsoonworld self-assigned this Jul 15, 2025
@jsoonworld jsoonworld added πŸ”€ merge λ‹€λ₯Έ λΈŒλžœμΉ˜μ™€ 병합 🦊μž₯순🦊 labels Jul 15, 2025
@jsoonworld jsoonworld merged commit bddb53a into main Jul 15, 2025
4 of 6 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Spring Security and introduces a custom authentication system, refactors the authentication service, and updates related controllers and Swagger definitions to use a new @Login annotation and JWT-based interceptor.

  • Replaces Spring Security filters with LoginCheckInterceptor and LoginUserArgumentResolver, and consolidates CORS and argument resolver into WebConfig
  • Refactors AuthService to handle sign-in, sign-up, token reissue, and user sync operations in one service using JwtProvider
  • Updates controllers and Swagger interfaces to use @Login for injecting the authenticated user ID, replaces old DTOs, and removes deprecated JWT provider classes

Reviewed Changes

Copilot reviewed 76 out of 78 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/test/java/org/terning/terningserver/service/ScrapServiceTest.java Entire test file commented out instead of removal
src/main/java/org/terning/terningserver/common/config/WebConfig.java Adds custom MVC config, argument resolver, and interceptor setup
src/main/java/org/terning/terningserver/auth/application/AuthService.java Consolidates authentication operations and removes filter chains
src/main/java/org/terning/terningserver/scrap/api/ScrapController.java Endpoints updated to use @Login; removes Spring Security imports
src/main/java/org/terning/terningserver/user/domain/User.java Enhances User entity with refresh token validation and builder
Comments suppressed due to low confidence (3)

src/main/java/org/terning/terningserver/scrap/api/ScrapSwagger.java:31

  • The updateScrapColor Swagger interface uses @PathVariable long scrapId, but the controller mapping uses {internshipAnnouncementId}. Synchronize parameter names or path templates to avoid binding errors.
            @Login long userId,

src/main/java/org/terning/terningserver/search/api/SearchSwagger.java:31

  • In the Swagger interface, sortBy is required by default, but the controller parameter is required=false. Consider adding required=false or a default value in the Swagger annotation to match controller behavior.
            @RequestParam("sortBy") String sortBy, Pageable pageable

src/main/java/org/terning/terningserver/auth/common/exception/AuthErrorCode.java:11

  • [nitpick] Unlike JwtErrorCode, AuthErrorCode does not prepend the PREFIX to the message. Consider adding a getMessage() method that prepends PREFIX for consistency in error responses.
    USER_ALREADY_EXIST(HttpStatus.BAD_REQUEST, "μœ μ €κ°€ 이미 μ‘΄μž¬ν•©λ‹ˆλ‹€."),

}
}
}
//package org.terning.terningserver.service;
Copy link

Copilot AI Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entire test class has been commented out rather than deleted. If these tests are no longer needed, consider removing the file or migrating tests instead of leaving large commented blocks.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ”€ merge λ‹€λ₯Έ λΈŒλžœμΉ˜μ™€ 병합 size/XXL 🦊μž₯순🦊

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants