This repository was archived by the owner on Apr 11, 2022. It is now read-only.
Fixed that gitignore exceptions would not work #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By excluding the whole `src/lib` folder, the exceptions for `src/lib/Magento` and `src/lib/PHPUnit` would not work. For exceptions (aka unignores) to work, the parent folder may not be ignored but only its content may.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By excluding the whole
src/libfolder, the exceptions forsrc/lib/Magentoandsrc/lib/PHPUnitwould not work. For exceptions (aka unignores) to work, the parent folder may not be ignored but only its content may.