Normalize plated hole circle shape for circuit-to-svg #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

techmannih wants to merge 1 commit into main from codex/fix-unsupported-plated-hole-shape-warnings

Owner

techmannih commented Sep 14, 2025

Summary

add utility to rewrite pcb_plated_hole elements with shape: "circle" into an oval representation
use the normalizer before PCB SVG generation so circuit-to-svg no longer warns about unsupported shapes
apply the same normalisation in test snapshot helper

Testing

bun test tests/components/primitive-components/plated-hole-pill.test.tsx (fails: Cannot find package 'bun-match-svg')
bun run format (fails: biome: command not found)

https://chatgpt.com/codex/tasks/task_e_68c63d46c7908328a83a2886cf890d03


          chore: add normalize plated hole util

70877db

techmannih added the codex label

— with

ChatGPT Codex Connector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels