Fix CAD model rotation after pack layout #22
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| const cadComponents = db.cad_component | ||
| .list() | ||
| .filter((cad) => cad.pcb_component_id && ids.has(cad.pcb_component_id)) | ||
|
|
||
| for (const cad of cadComponents) { | ||
| const existingRotation = cad.rotation ?? {} | ||
| db.cad_component.update(cad.cad_component_id, { | ||
| rotation: { | ||
| ...existingRotation, | ||
| z: (existingRotation.z ?? 0) + rotationDegrees, | ||
| }, |
There was a problem hiding this comment.
The new updateCadComponentRotations helper always adds rotationDegrees to the CAD model’s rotation.z. For components on the bottom layer the CAD model rotation is defined as -(accumulatedRotation + offset) + 180 (see CadModel initialization), so applying a positive delta here actually reverses the intended rotation when a pack result rotates the component. After this change, any bottom-layer part that is rotated during packing will have its 3D model spun in the opposite direction. Consider looking up each component’s layer and subtracting the delta for bottom-layer parts (or otherwise mirroring the sign) before updating rotation.z.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f120703ec08328b74f59a1a395774e