print newest deps #2792
print newest deps #2792
Conversation
|
Thanks for this patch. I think overall it's good to surface this information, but the way it's presented in this implementation is not particularly clear. Simply saying There's also a couple technical issues with it; for one it removes Also it appears to bring in a new dependency, which causes a lot of extra work for downstream packagers. As far as I can tell, this is only being used for a single function, which duplicates logic already available from Aether: https://github.com/technomancy/leiningen/blob/master/leiningen-core/src/leiningen/core/pedantic.clj#L68 Let's use the existing implementation instead of bringing in something redundant. |
|
According to you suggestion, I make some modifications. |
|
Sorry, I haven't gotten a chance to look at this yet, but I don't think it needs to be closed. Was that intentional? |
|
II'd like to think about this modification again. I think there are still some problems, but you can also take a look at it first and suggest some changes. |
|
I will make some fixes. |
|
Fix is completed. |
And match the configuration arrangments for the host, i.e. support LEIN_REPL_SOCKET, :repl-options :socket, and an nrepl config :socket.
This relies on an unreleased version of nrepl (likely to be 1.0.0). It also doesn't completely clean up after itself because if nothing else, the (server ...) future will be blocked forever on a promise.
…from robin_lilli/leiningen:robin_lilli-patch-1 into main Reviewed-on: https://codeberg.org/leiningen/leiningen/pulls/47
Also prefix it with semicolons to avoid interfering with data.
Just helps avoid interfering with data in cases where the output is parsed.
Also update the tutorial that mentions this. The Japanese translation of the tutorial still has the incorrect description; we will need help updating it. See https://codeberg.org/leiningen/leiningen/issues/46
…m oyakushev/leiningen:nrepl-1.3 into main Reviewed-on: https://codeberg.org/leiningen/leiningen/pulls/53
Although a project's :active-profiles metadata is not currently part of the publically specified API, it can be useful in middlewares. Previously init-profiles, which is used by unmerge-profiles carried over the :active-profiles from the incoming project, and since :active-profiles is built solely via conj, this ended up not removing profiles that were being unmerged. To fix that, just clear the active profiles in init-profiles before it rebuilds them.
…ia lein pom/java' (technomancy#54) from rlb/leiningen:unmerge-active-profiles-too into main Reviewed-on: https://codeberg.org/leiningen/leiningen/pulls/54
Nrepl was upgraded to 1.3.0 in f82f809
… from gordonsyme/leiningen:gordon/sync-bootclasspath-deps into main Reviewed-on: https://codeberg.org/leiningen/leiningen/pulls/55
…(analogous to tree-data)
…on.' (technomancy#63) from andrew-alves/leiningen:remove-pallet-link into main Reviewed-on: https://codeberg.org/leiningen/leiningen/pulls/63
|
Sorry about this; for some reason github did not notify me about the changes here. This is a lot better. There's still a few issues I'd like to see fixed.
|
This is redundant now, pomegranate already protects us from HTTP downloads and will give a decent error when you try to use one.
12 participants
When conflict deps found, print the depency of newest version.