Skip to content

Conversation

@jadbalout
Copy link
Contributor

@jadbalout jadbalout commented Jul 31, 2016

http://prnt.sc/bzv9lt
http://prntscr.com/bzvgbq
CSS expert needed to fix circled image please.

@BobbyWibowo
Copy link

BobbyWibowo commented Jul 31, 2016

Honestly, I can't ever view picture in Lightshot. Mind uploading them somewhere else? 😕

@jadbalout
Copy link
Contributor Author

@BobbyWibowo nott sure if that will work but try:
https://slack-imgs.com/?c=1&url=http%3A%2F%2Fimage.prntscr.com%2Fimage%2F5db7aea66a8a4507927840ac4548dc5f.png
also mind testing it pls:?

@BobbyWibowo
Copy link

Honestly, that's nice. I think I'm gonna implement that to my fork (it's a personal build thingy). Thanks!
👍

@jadbalout
Copy link
Contributor Author

jadbalout commented Jul 31, 2016

@BobbyWibowo once you do implement it, tell me if it works, I did a good amount of changes and I'm not sure whether I uploaded them all or not.

@BobbyWibowo
Copy link

I actually ended up writing it from scratch since my personal build was based on wchill/refactor branch and I already had a few customization beforehand, but well, here's how I implemented it: https://github.com/BobbyWibowo/OpenPoGoWeb/commit/4f9fe1937973900b7d29de1528f293f59c30361c#commitcomment-18464499. Feel free to salvage the styling if you want.

@MaxLeiter
Copy link
Contributor

MaxLeiter commented Aug 1, 2016

I think the circular image can wait for another PR, thanks!

👍

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants