(fixed #4064) #4055 の問題に対する opLikePlugin の独自修正を取り除く#7
Open
nishizoe wants to merge 3 commits intotejimaya:masterfrom
Open
(fixed #4064) #4055 の問題に対する opLikePlugin の独自修正を取り除く#7nishizoe wants to merge 3 commits intotejimaya:masterfrom
nishizoe wants to merge 3 commits intotejimaya:masterfrom
Conversation
upsilon
suggested changes
Dec 5, 2016
| $url = $notificationItem['url']; | ||
| if ($url) | ||
| { | ||
| preg_match('/(\/timeline\/show\/id|\/diary|\/communityEvent|\/communityTopic)\/[0-9]+/', $url, $m); |
There was a problem hiding this comment.
preg_match でマッチしなかった場合は $notificationItem['url'] に変更を加えないための分岐が必要です
| { | ||
| /* | ||
| * 下記の条件に一致する通知URLを一括で変更: | ||
| * * url に '/timeline/', '/diary/', '/communityEvent/', '/communityTopic/' が含まれ、 |
There was a problem hiding this comment.
メッセージ機能の通知 (/message/read/:id) は対応不要でしょうか？
Author
There was a problem hiding this comment.
メッセージ機能の通知 (/message/read/:id) は、opLikePlugin 経由で通知されているものではないので、今回の問題には当たりませんのでここでの対応は不要です。
upsilon
approved these changes
Dec 5, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://redmine.openpne.jp/issues/4064