fix(adapter): eliminate data race on shared event field#2590
Open
chmouel wants to merge 2 commits intotektoncd:mainfrom
Open
fix(adapter): eliminate data race on shared event field#2590chmouel wants to merge 2 commits intotektoncd:mainfrom
chmouel wants to merge 2 commits intotektoncd:mainfrom
Conversation
The listener struct had a shared `event *info.Event` field that was written to by concurrent HTTP request handlers. When two requests arrived simultaneously (e.g. a push event and an incoming webhook), both would write to l.event, causing the push handler to read the incoming handler's event data. This resulted in the push event being processed as event_type=incoming, matching the wrong PipelineRun triggers and creating duplicate PipelineRuns. Remove `event` from the listener struct and make it a local variable per request in handleEvent. Pass it as a parameter to detectIncoming and processIncoming so each concurrent request operates on its own isolated event object. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com> Assisted-by: Claude Opus 4.6 (via Claude Code)
Member
Author
|
@zakisk i think that what you were trying to do last time? this mostly is an issue with incoming webhooks, since we are sharing the info.Event pointer in there, so this PR makes it local, PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description of the Change
The listener struct had a shared
event *info.Eventfield that waswritten to by concurrent HTTP request handlers. When two requests
arrived simultaneously (e.g. a push event and an incoming webhook),
both would write to l.event, causing the push handler to read the
incoming handler's event data. This resulted in the push event being
processed as event_type=incoming, matching the wrong PipelineRun
triggers and creating duplicate PipelineRuns.
Remove
eventfrom the listener struct and make it a local variableper request in handleEvent. Pass it as a parameter to detectIncoming
and processIncoming so each concurrent request operates on its own
isolated event object.
Signed-off-by: Chmouel Boudjnah chmouel@redhat.com
Assisted-by: Claude Opus 4.6 (via Claude Code)
🔗 Linked GitHub Issue
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.