Add checks that overrides are compatible with overridden signatures#350
Draft
mikesamuel wants to merge 1 commit intomainfrom
Draft
Add checks that overrides are compatible with overridden signatures#350mikesamuel wants to merge 1 commit intomainfrom
mikesamuel wants to merge 1 commit intomainfrom
Conversation
This commit implements override checking, but it currently breaks because we have not been careful about overrides especially whether a method bubbles or not. I'm making this a draft and will try to address some of those problems in follow-on commits. Signed-off-by: Mike Samuel <mikesamuel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements override checking, but it currently breaks because we have not been careful about overrides especially whether a method bubbles or not. I'm making this a draft and will try to address some of those problems in follow-on commits.