Enable concurrent payload visiting#244
Open
jmaeagle99 wants to merge 1 commit intotemporalio:masterfrom
Open
Conversation
Only spawn gorountines after semaphore is acquired More tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Allow payload visitor to optionally concurrently visit payloads.
Payloadsare visited together and count as 1 visit). Outside of concurrency, the only semantic difference is that cancellation will short-circuit graph traversal (regardless of the concurrent visitors returning an error or not) whereas the sequential mode relied on the visitor to return an error.Why?
To enable more efficient visiting behavior when needed. For example, if the visitor were used to upload or download payloads to/from external storage, there should be some concurrency enabled to avoid sequential uploads and downloads.
How did you test it?
More unit tests that ensure concurrency is opt-in, that it doesn't go over the concurrency limit, and that concurrency is actually exhibited.
Potential risks
Low; this is an opt-in setting on the payload visitor is off by default. The sequential path has been preserved without using goroutines.