Fix first_execution_run_id comments on Cancel and Terminate RPCs#755
Open
dandavison wants to merge 1 commit intomasterfrom
Open
Fix first_execution_run_id comments on Cancel and Terminate RPCs#755dandavison wants to merge 1 commit intomasterfrom
dandavison wants to merge 1 commit intomasterfrom
Conversation
The comments on RequestCancelWorkflowExecution and TerminateWorkflowExecution claimed that first_execution_run_id validates against either the most recent or specified (by run id) execution. In reality, the server unconditionally ignores the run id when first_execution_run_id is set, always resolving to the most recent execution for the workflow id. The UpdateWorkflowExecution comment is left unchanged because its server implementation does respect the run id when set.
dandavison
force-pushed
the
fix-first-execution-run-id-comments
branch
from
592d53b to
37f9840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proto comments on
first_execution_run_idinRequestCancelWorkflowExecutionRequestandTerminateWorkflowExecutionRequestclaimed that when a run ID is set onworkflow_execution, validation would demand that that run descends fromfirst_execution_run_id. In reality, the server unconditionally ignores theworkflow_executionrun ID whenfirst_execution_run_idis set, resolves to the most recent execution, and then checks that that descends fromfirst_execution_run_id:requestcancelworkflow/api.go:32-34terminateworkflow/api.go:33-35The
UpdateWorkflowExecutionRequestcomment is left unchanged because its server implementation does pass theworkflow_executionrun ID through to execution resolution, and validatesfirst_execution_run_idseparately after loading the execution.