Refactor current stream forwarding code into StreamForwarder #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai719
changed the title
temporal-nick
approved these changes
Nov 17, 2025
Contributor
temporal-nick
left a comment
temporal-nick
left a comment
There was a problem hiding this comment.
High-level comment: this code was written before I learned more about Contexts, it may be possible to also clean up the Recv() code by using the targetStreamServer.Context() to exit early. I haven't looked into whether that is definitely the case though.
proxy/admin_stream_transfer.go
Outdated
| defer cancel() | ||
|
|
||
| // The underlying adminClient will try to grab a connection when we call StreamWorkflowReplicationMessages. | ||
| // The connection is separately managed, so we want to see how long it takes to establish that conn. |
Contributor
There was a problem hiding this comment.
Dead comment, nothing is monitoring the time here
proxy/admin_stream_transfer.go
Outdated
| // ^targetStreamServer ^sourceStreamClient | ||
| // | ||
| // We can freely close sourceStreamClient with closeSend. gRPC will only cancel targetStreamServer when we return from | ||
| // this function. |
Contributor
There was a problem hiding this comment.
Comment out of date: "...when we return from the service handler"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Refactor current stream forwarding code into StreamForwarder.
Why?
Later we will add StreamSender, StreamReceiver to support proxy routing of replication messages. Refactor existing code into StreamForwarder will make code structure more clear.
Checklist
Closes
How was this tested:
Covered by existing tests.
Any docs updates needed?